feat: Add ApplicationEmoji to EmojiResolvable and MessageReaction#emoji #10477
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Moebits
changed the title
|
This may also need updating discord.js/packages/discord.js/src/managers/BaseGuildEmojiManager.js Lines 23 to 28 in a11ff75 |
|
Thanks I updated BaseGuildEmojiManager.js and it seemed to fix the equality comparison with |
vladfrangu
approved these changes
Sep 3, 2024
TAEMBO
reviewed
Sep 3, 2024
Moebits
changed the title
Qjuh
approved these changes
Sep 4, 2024
TAEMBO
approved these changes
Sep 4, 2024
vladfrangu
requested changes
Sep 5, 2024
vladfrangu
approved these changes
Sep 11, 2024
didinele
approved these changes
Oct 1, 2024
kyranet
approved these changes
Oct 1, 2024
Jiralite
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ji (#10477) * types: add ApplicationEmoji to EmojiResolvable * typings: add ApplicationEmoji to MessageReaction#emoji * removed ApplicationEmoji from MessageReaction * update BaseGuildEmojiManager * chore: lint error * feat: add ApplicationEmoji to MessageReaction#emoji getter * refactor: check application emojis first --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
When using typescript you can't react to a message with an
ApplicationEmojibecauseEmojiResolvablelacks the type.Edit: I also updated BaseGuildEmojiManager.js and added
ApplicationEmojito theMessageReaction#emojigetter.Status and versioning classification: